[PATCH] D87864: AMDGPU: Check global FP atomics match default FP mode

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:11807
     if (AS == AMDGPUAS::GLOBAL_ADDRESS && Subtarget->hasAtomicFaddInsts()) {
+      if (!fpModeMatchesGlobalFPAtomicMode(RMW))
+        return AtomicExpansionKind::CmpXChg;
----------------
rampitec wrote:
> arsenm wrote:
> > rampitec wrote:
> > > Does it depend on the address space? What about LDS atomics, don't you need to move this out of the if statement?
> > I'm not sure
> Looks like they all behave the same, support denorm modes and always round nearest to zero.
RNE of course.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87864/new/

https://reviews.llvm.org/D87864