[PATCH] D87882: [AMDGPU] Fix merging m0 inits

[Piotr Sobczak via Phabricator via llvm-commits]

piotr created this revision.
Herald added subscribers: llvm-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
Herald added a project: LLVM.
piotr requested review of this revision.
Herald added a subscriber: wdng.

Fix incorrect merges of m0 inits in loops.

It was assumed that if a clobbering instruction appears in
the same block as an init and the clobbering instruction
does not dominate the init then it does not interfere with
init.

This does not work in the presence of loops, where in this
scenario, the clobbering instruction does interfere with
the init in another iteration.

To fix this, do not check for block equality and defer the
decision to the predecessor check.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87882

Files:
  llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp
  llvm/test/CodeGen/AMDGPU/merge-m0.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87882.292705.patch
Type: text/x-patch
Size: 9967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200918/8c3fc68f/attachment.bin>