[PATCH] D86988: [Inliner] Run always-inliner in inliner-wrapper

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 21:00:24 PDT 2020


aeubanks added a comment.

Compile times look unaffected: http://llvm-compile-time-tracker.com/?config=O3&stat=instructions&remote=aeubanks (thanks nikic!)

In D86988#2275832 <https://reviews.llvm.org/D86988#2275832>, @davidxl wrote:

> The AlwaysInliner does not operate on DAG, but depend on function order in the module, so it is possible to regress with the change. I don't have strong opinion on this, but you want want to hear others opinion.

I don't mean that the pass is a CGSCC pass, I mean that this change makes any modules with non-mutually recursive always_inline functions work as intended, whereas before that didn't always work.
Mutually recursive always_inline functions can't work, so we shouldn't care about that too much.

Who else should I ask about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86988/new/

https://reviews.llvm.org/D86988



More information about the llvm-commits mailing list