[PATCH] D87841: [openmp][libomptarget] Include header from LLVM source tree

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 18:40:44 PDT 2020


JonChesterfield added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:33
 ///
 /// Example usage in libomptarget/deviceRTLs:
 ///   #include "OMPGridValues.h"
----------------
saiislam wrote:
> You might want to update these comments also. I have a NFC patch under review for exactly this D86232. Feel free to bring it in here.
Thanks for the cross reference. I want to keep this review focused on accepting the new dependency edge.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87841/new/

https://reviews.llvm.org/D87841



More information about the llvm-commits mailing list