[PATCH] D87866: IR: Move denormal mode parsing from MachineFunction to Function

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 17:19:27 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one nit you might want to consider



================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:277
   // TODO: Should probably avoid the connection to the IR and store directly
   // in the MachineFunction.
+  return F.getDenormalMode(FPType);
----------------
Is the TODO still accurate? We seem to go in the opposite direction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87866/new/

https://reviews.llvm.org/D87866



More information about the llvm-commits mailing list