[PATCH] D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/unittests/Lower/OpenMPLoweringTest.cpp:86
   auto insertPt = mlirOpBuilder->saveInsertionPoint();
+  mlir::Value numThreads;
+  mlir::Attribute defaultValue, procBindValue;
----------------
What is the plan with those unit tests once the bridge and lit test will be upstream. As I said previously, I don't think those test are testing the actual lowering and the API they use is probably tested in the respective MLIR tests. Are we going to delete them once we have the lit one or do we have to maintain both? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87846/new/

https://reviews.llvm.org/D87846