[PATCH] D87870: [GISel] Add new combines for G_FMUL

Michael Kitzan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 16:24:03 PDT 2020


mkitzan added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2206
+    if (CmpMI->getOpcode() != TargetOpcode::G_FCMP ||
+        !matchFConstantOp(CmpMI->getOperand(3), 0.0) ||
+        Src0 != CmpMI->getOperand(2).getReg())
----------------
Decided against using the new `matchOperandIsFPZero` here, because it would require `matchOperandIsFPZero` not to validate that the `FConstant` operand could replace the dst of its use (which would diverge from the semantics of `matchOperandIsZero`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87870/new/

https://reviews.llvm.org/D87870



More information about the llvm-commits mailing list