[PATCH] D87780: [lld-macho] Export trie addresses should be relative to the image base

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 15:58:59 PDT 2020


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/MachO/ExportTrie.h:36
 
+  uint64_t imageBase = 0;
   std::vector<const Symbol *> exported;
----------------
Nit: do we need this initialization, given that `setImageBase` should always be called?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87780/new/

https://reviews.llvm.org/D87780



More information about the llvm-commits mailing list