[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:10054
+
+  case Intrinsic::ppc_altivec_mtvsrbm: {
+    // The llvm.ppc.altivec.mtvsrbm intrinsic can correspond to two different
----------------
steven.zhang wrote:
> Can we handle this inside the .td ? i.e. change the definition of the instr as:
> ```
>   def MTVSRBMI : DXForm<4, 10, (outs vrrc:$vD), (ins u8imm64:$D),
>                         "mtvsrbmi $vD, $D", IIC_VecGeneral,
>                         [(set v16i8:$vD,
>                               (int_ppc_altivec_mtvsrbm imm:$D))]>;
> ```
> And add the missing u8imm64 as what we did for u16imm64 ?
I actually made a mistake when I was implementing this patch. The immediate should fit within 16-bits and not 8-bits. Sorry about that. I will update the patch to remove this handling as it is unnecessary and not correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82725/new/

https://reviews.llvm.org/D82725