[PATCH] D84359: [PowerPC] Add vector pair load/store instructions and vector pair register class

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 14:52:02 PDT 2020


lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:598
 
+void PPCInstPrinter::printVSRpEvenReg(const MCInst *MI, unsigned OpNo,
+                                      raw_ostream &O) {
----------------
This function looks like a subset of what `PPCInstPrinter::printOperand()` does..  can we not just use that function instead?


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.h:162
+        }
+
         return RegName + 1;
----------------
nit: no need for the extra empty line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84359/new/

https://reviews.llvm.org/D84359



More information about the llvm-commits mailing list