[PATCH] D86972: [IRSim] Adding a basic similarity identifier.

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:644
+  /// Marked true if there are currently items in SimilarityCandidates.
+  bool ModulesAnalyzed = false;
+
----------------
I think it would force better hygiene on it if instead of being a flag, this were represented as SimilarityCandidates being an Optional<>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86972/new/

https://reviews.llvm.org/D86972