[PATCH] D87736: [PDB] Split TypeServerSource and extend type index map lifetime

[Reid "Away June-Sep" Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Thanks!



================
Comment at: lld/COFF/InputFiles.cpp:793
+    if (!debugChunks.empty())
+      debugTypesObj = makeTpiSource(this);
     return;
----------------
aganea wrote:
> I am fine //without// this, I simply forgot about this case, where we had symbols but no types. Would that affect your tpi-index in D87805? This empty `TpiSource` will also receive an index and will be scheduled for doing, essentially, nothing? I am fine if you want to revert to an extra `if` below, whichever you think is the best.
I think I like this version better: it's one less nullable pointer to check for later. There aren't many of these object files without types, they are mostly assembly files .debug$F FPO data, so the extra memory usage shouldn't be a concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87736/new/

https://reviews.llvm.org/D87736