[PATCH] D87844: [CodeGen] Fixing inconsistent ABI mangling of vlaues in SelectionDAGBuilder

Thu Sep 17 11:08:52 PDT 2020

efriedma added a comment.

If I'm following this correctly, with this change, getABIRegCopyCC has one remaining caller, and that call always returns None.  So getABIRegCopyCC is useless, and the CallConv member of RegsForValue is always None?  It seems weird that all this code got built up around a useless operation, but I guess that sort of thing can happen.

@arsenm Do you remember why you added getABIRegCopyCC in the first place?

================
Comment at: llvm/test/CodeGen/ARM/pr47454.ll:5
+; Function Attrs: nobuiltin nounwind
+define internal fastcc half @getConstant() unnamed_addr #0 {
+Entry:
----------------
Please remove the definitions of getConstant and isEqual if they aren't relevant.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87844/new/

https://reviews.llvm.org/D87844