[PATCH] D87478: scudo: Remove the THREADLOCAL macro.

Thu Sep 17 09:18:04 PDT 2020

russell.gallop added a comment.

In D87478#2267034 <https://reviews.llvm.org/D87478#2267034>, @cryptoad wrote:

> I think that I one point in time I tried thread_local but a compiler (can't remember which one) was complaining about the constructors not being trivial or something to that extent.
> This is fairly blurry at this point, so I am sorry if this is not very helpful, but I just want to make sure this would work on all platforms with gcc/clang.

For reference, I hit something similar at the beginning of this year with LLVM_THREAD_LOCAL on MacOS: https://reviews.llvm.org/D71059#1806509 Maybe it was similar to that.

> This was tested with clang but I also tried g++ 9.3.0 and it compiled there. Beyond that I reckon we should just rely on bots.

Agreed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87478/new/

https://reviews.llvm.org/D87478