[PATCH] D87681: [ARM] Improve VPT predicate tracking

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:165
+    static SmallVector<VPTBlock, 4> Blocks;
+    static SetVector<MachineInstr *> CurrentPredicate;
+    static std::map<MachineInstr *,
----------------
SjoerdMeijer wrote:
> In one of the other patches, you had a nice comment explaining the chaining and AND'ing of predicates. Is that applicable here, would that comment be good to have here? 
Yeah, I had forgotten that there's already a comment describing it at the top of the file.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1371
+        LoLoop.ToRemove.insert(Insts.front());
+        for (unsigned i = 1; i < Insts.size(); ++i)
+          RemovePredicate(Insts[i]);
----------------
SjoerdMeijer wrote:
> just checking, should this be `<=`?
No, that would be out of bounds.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87681/new/

https://reviews.llvm.org/D87681