[PATCH] D87746: [mlir] Fix of updating function signature in normalizing memrefs

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 02:10:29 PDT 2020


bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/test/lib/Dialect/Test/TestOps.td:635
+  let description = [{
+    The "test.op_entrypoint" function indicates the main entry point.
+  }];
----------------
It's still not clear what this means. Did you mean to say it's an arbitrary op with a reference to a function symbol? Why is even an entry point in the context here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87746/new/

https://reviews.llvm.org/D87746



More information about the llvm-commits mailing list