[PATCH] D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

In D87740#2277446 <https://reviews.llvm.org/D87740#2277446>, @hoy wrote:

> Thanks for the fix! LGTM.
>
> I'm also seeing `InstrProfSymtab` is there to handle MD5-based names for PGO instrumentation. Not sure how it is used exactly. @wmi Have we thought about using that for AutoFDO?

Looks like there are some functionality overlap between InstrProfSymtab and AutoFDO MD5 lookup. It is worth noting that for Instrumentation PGO profile, function names present in the profile, and for compact format profile in AutoFDO, there are only MD5 and no names are present in the profile -- in order to keep the profile compact, so it is not that trivial to extract the common part but it is definitely possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87740/new/

https://reviews.llvm.org/D87740