[PATCH] D85685: Support dwarf fission for wasm object files

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

In D85685#2277998 <https://reviews.llvm.org/D85685#2277998>, @dschuff wrote:

> 



> Yeah, ELF splits ELFWriter out from ELFObjectWriter, and then instantiates it twice. It's all because ELFObjectWriter has to derive from MCObjectWriter which was clearly not designed with this in mind. I found the class split to be a bit awkward, but I don't really have strong feelings about it either way.

I should add that what I do instead is just have one instance, and just reset the relevant state before calling writeOneObject again. So the structure is cleaner but the downside of that is that the state has to be manually reset.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85685/new/

https://reviews.llvm.org/D85685