[PATCH] D85293: [DebugInfo] Simplify DIEInteger::SizeOf().

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 10:01:36 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - thanks!



================
Comment at: llvm/unittests/CodeGen/DIEHashTest.cpp:34-39
+  void setupTestPrinter() {
+    auto ExpectedTestPrinter = TestAsmPrinter::create(
+        sys::getDefaultTargetTriple(), /*DwarfVersion=*/4, dwarf::DWARF32);
+    ASSERT_THAT_EXPECTED(ExpectedTestPrinter, Succeeded());
+    TestPrinter = std::move(ExpectedTestPrinter.get());
+  }
----------------
I'd probably roll this into getAsmPrinter - but up to you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85293/new/

https://reviews.llvm.org/D85293



More information about the llvm-commits mailing list