[PATCH] D87472: AMDGPU: Clear offset register when using local stack area

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 08:31:19 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/stack-pointer-offset-relative-frameindex.ll:45
+; GCN-NEXT:    s_clause 0x1
+; GCN-NEXT:    buffer_load_dword v0, v40, s[36:39], 0 offen
+; GCN-NEXT:    buffer_load_dword v1, v40, s[36:39], 0 offen offset:4
----------------
rampitec wrote:
> So it does not use offset at all now? Isn't it a regression?
No, an offset isn't necessary anymore since we now increment the base pointer in the SRD in the kernel prolog. This is one of the cleanups that enables


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87472/new/

https://reviews.llvm.org/D87472



More information about the llvm-commits mailing list