[PATCH] D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model

Wed Sep 16 07:30:44 PDT 2020

fhahn added a comment.

In D86879#2274099 <https://reviews.llvm.org/D86879#2274099>, @jasonliu wrote:

> In D86879#2274076 <https://reviews.llvm.org/D86879#2274076>, @nemanjai wrote:
>
>> In D86879#2274025 <https://reviews.llvm.org/D86879#2274025>, @hubert.reinterpretcast wrote:
>>
>>> We believe that the test is necessarily large. Has the associated bot encountered similar issues before? What was the recommended fix to retain the test in more appropriate environments?
>>
>> Perhaps the test case should be restricted to some key platforms where cross-compilation to AIX is relevant? Perhaps `Linux` (PPC is already required).
>
> I could add 
> `# REQUIRES: aix || linux `
> to the test if that helps.

The problem here is with expensive checks, which makes it take too long I think. It works fine on Darwin bots without expensive checks. If it is not possible to reduce the size of the test, then we need to disable it at least for the configuration used for  http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive. I am not sure if there's another way to force a big gap in PPC assembly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86879/new/

https://reviews.llvm.org/D86879