[PATCH] D87667: [Support/Path] Add path::is_gnu_style_absolute

Vinicius Tinti via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 19:14:39 PDT 2020


tinti added a comment.

In D87667#2273502 <https://reviews.llvm.org/D87667#2273502>, @jhenderson wrote:

>> On Windows, paths starting with drive letter pattern are absolute.
>
> This isn't a difference is it? That's also the behaviour for `is_absolute`, I believe?

I forgot this comment.

`is_absolute` is really hard to read. But I think you are right.

I think it considers `c:\` as absolute but does not `c:` [1].

[1] https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/Path.cpp#L69


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87667/new/

https://reviews.llvm.org/D87667



More information about the llvm-commits mailing list