[PATCH] D81803: [Support] PR42623: Avoid setting the delete-on-close bit for TempFile

Ronald Wampler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 18:23:35 PDT 2020


rdwampler added a comment.



> We could accept a more targeted fix. Does the call to CreateFile fail with the delete on close disposition? If so, we could retry without the disposition if it fails.

The call to CreateFile does succeed, but it’s the subsequent writes to the file handle that fails. Perhaps, we can try to detect if we are creating a file on a network drive using GetDriveType and if so avoid setting delete on close?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81803/new/

https://reviews.llvm.org/D81803



More information about the llvm-commits mailing list