[PATCH] D87713: [NewPM] Port -print-alias-sets to NPM

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/AliasSetTracker.cpp:752
       auto &AAWP = getAnalysis<AAResultsWrapperPass>();
-      Tracker = new AliasSetTracker(AAWP.getAAResults());
+      AliasSetTracker Tracker(AAWP.getAAResults());
       errs() << "Alias sets for function '" << F.getName() << "':\n";
----------------
ychen wrote:
> No strong feeling but I'm not really sure how big AliasSetTracker it could go or if it owns a lot of memory. This does not look like a critical path to make putting it on stack worthwhile. Play safe and keep it on the heap?
AliasSetTracker doesn't look special, it seems like a normal class with normal member variables with normal sizes.
This was mostly due to me really not liking raw news/deletes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87713/new/

https://reviews.llvm.org/D87713