[PATCH] D87628: [AArch64][GlobalISel] Select unscaled loads/stores in manual selector

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:2358
+      if (auto UnscaledOpc =
+              selectUnscaledLoadStoreOp(GenericOpc, RegBankID, MemSizeInBits)) {
+        AddrModeFns = selectAddrModeUnscaled(PtrOp, MemSizeInBytes);
----------------
selectUnscaledLoadStoreOp can take the bool IsStore for the first arg instead of a full opcode.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:2367
+
+      if (NewOpc == GenericOpc)
+        return nullptr;
----------------
When would this happen?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87628/new/

https://reviews.llvm.org/D87628