[PATCH] D86968: [IRSim] Adding IR Instruction Mapper

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:106
+  /// The types of the operands in the Instruction.
+  SmallVector<Type *, 4> OperTypes;
+  /// The legality of the wrapped instruction. This is informed by InstrType,
----------------
AndrewLitteken wrote:
> plotfi wrote:
> > How are OperTypes different from OperVals getTypes() ? 
> There isn't any difference, it is just easier to access them since the types need to be accessed often, and in different ways than OperVals.
> There isn't any difference, it is just easier to access them since the types need to be accessed often, and in different ways than OperVals.

Can these be dropped then? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86968/new/

https://reviews.llvm.org/D86968