[PATCH] D87609: [Suport][cmake] Change LLVM_INTEGRATED_CRT_ALLOC to a path instead of a boolean

Russell Gallop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 09:21:27 PDT 2020


russell.gallop accepted this revision.
russell.gallop added a comment.
This revision is now accepted and ready to land.

One small comment. Apart from that, LGTM.



================
Comment at: llvm/CMakeLists.txt:516
 endif()
 
 # Define options to control the inclusion and default build behavior for
----------------
I think it might make more sense to put all of the new LLVM_INTEGRATED_CRT_ALLOC code further up now, such as here, so it is not under "Define options to control the inclusion..." section which is (almost entirely) boolean options to enable build targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87609/new/

https://reviews.llvm.org/D87609



More information about the llvm-commits mailing list