[PATCH] D87674: [AMDGPU] Insert waitcnt after returning from call

[Sebastian Neubauer via Phabricator via llvm-commits]

Flakebi added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:885
+      (MI.isReturn() && MI.isCall() && !callWaitsOnFunctionEntry())) {
+    if (callWaitsOnFunctionReturn(MI))
+      Wait = Wait.combined(AMDGPU::Waitcnt::allZero(ST->hasVscnt()));
----------------
madhur13490 wrote:
> please fuse these two "if" conditions. They are already unreadable.
Fusing these conditions would change the behavior as the else is executed (and insert waitcnts), so I can’t :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87674/new/

https://reviews.llvm.org/D87674