[PATCH] D87697: Do not construct std::string from nullptr

Yuriy Chernyshov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 08:03:03 PDT 2020


georgthegreat updated this revision to Diff 291933.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87697/new/

https://reviews.llvm.org/D87697

Files:
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp


Index: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
+++ llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
@@ -1306,8 +1306,6 @@
     else
       return "u32";
   }
-  llvm_unreachable("unexpected type");
-  return nullptr;
 }

 void NVPTXAsmPrinter::emitPTXGlobalVariable(const GlobalVariable *GVar,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87697.291933.patch
Type: text/x-patch
Size: 403 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200915/ada01f67/attachment.bin>


More information about the llvm-commits mailing list