[PATCH] D87045: [LoopNest] Handle loop-nest passes in LoopPassManager

Ta-Wei Tu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 06:02:30 PDT 2020


TaWeiTu added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPassManager.cpp:65
+    Optional<PreservedAnalyses> PassPA;
+    if (!PassCategories.test(I)) {
+      auto &Pass = LoopPasses[LoopPassIndex++];
----------------
etiotto wrote:
> This isn't that clear, perhaps use something like `!isa<LoopNestPass>(Pass)` ?
Hi, thanks for the suggestion! Do you think it's clear enough now after renaming it to `IsLoopNestPass`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87045/new/

https://reviews.llvm.org/D87045



More information about the llvm-commits mailing list