[PATCH] D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 05:59:12 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:62
+    if (Error Err = AddrTable.extractV5(AddrData, &Offset, /*CUAddrSize=*/0,
+                                        DiscardError))
+      return Err;
----------------
MaskRay wrote:
> `extractV5(..., consumeError)`
Nice suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87601/new/

https://reviews.llvm.org/D87601



More information about the llvm-commits mailing list