[PATCH] D87612: [llvm-readobj][test] - Improve section-symbols.test

Tue Sep 15 05:49:58 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-symbols.test:115-118
+## Test --relocations option.
+## FIXME: relocations should print section symbol names when them are not empty.
+# RUN: llvm-readobj %t1 --relocations 2>&1 | FileCheck %s -DFILE=%t1 --check-prefix=LLVM-RELOCS
+# RUN: llvm-readelf %t1 --relocations 2>&1 | FileCheck %s -DFILE=%t1 --check-prefix=GNU-RELOCS
----------------
grimar wrote:
> grimar wrote:
> > jhenderson wrote:
> > > Is there any reason to do this in a separate run? You could do `llvm-readobj --symbols --relocations` at the same time.
> > The first test contains constructions like `2> %t.llvm.err1` and then checks the stderr output separatelly for `--symbols`
> > I am not sure how much it is useful honestly. I think more useful is to check an exact output to reveal places where we print warnings.
> > Are you OK if I change `2> %t.llvm.err1` to `2>&1` and merge these tests then?
> So, I've leaved this place as is for now, but will be happy to merge tests if you think that it is fine.
I think we can merge the tests. I think the motivation for the output being separate before isn't a particularly strong one given the current code state.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87612/new/

https://reviews.llvm.org/D87612