[PATCH] D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:60
+    // still represent such sections.
+    auto DiscardError = [](Error Err) { consumeError(std::move(Err)); };
+    if (Error Err = AddrTable.extractV5(AddrData, &Offset, /*CUAddrSize=*/0,
----------------
Delete DiscardError


================
Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:62
+    if (Error Err = AddrTable.extractV5(AddrData, &Offset, /*CUAddrSize=*/0,
+                                        DiscardError))
+      return Err;
----------------
`extractV5(..., consumeError)`


================
Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:64
+      return Err;
+    AddrTables.push_back({});
+    for (uint64_t Addr : AddrTable.getAddressEntries()) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87601/new/

https://reviews.llvm.org/D87601