[polly] e71cda2 - [Windows][Polly] Disable LLVMPolly module for all compilers on Windows

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 23:13:12 PDT 2020


Author: Mateusz Mikuła
Date: 2020-09-15T09:12:38+03:00
New Revision: e71cda21d71c4c92731ec7fe8345d04395a630b7

URL: https://github.com/llvm/llvm-project/commit/e71cda21d71c4c92731ec7fe8345d04395a630b7
DIFF: https://github.com/llvm/llvm-project/commit/e71cda21d71c4c92731ec7fe8345d04395a630b7.diff

LOG: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows

Before this patch, the cmake disabled loadable modules when compiling
with Visual Studio. However, the reason for this is a limitation of the
Windows DLLs, thus this restriction should apply to any compiler for the
Windows platform, such as MinGW, Cygwin, icc, etc.

Differential Revision: https://reviews.llvm.org/D87524

Added: 
    

Modified: 
    polly/cmake/CMakeLists.txt
    polly/lib/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/polly/cmake/CMakeLists.txt b/polly/cmake/CMakeLists.txt
index fd8028a8937a..7cc129ba2e90 100644
--- a/polly/cmake/CMakeLists.txt
+++ b/polly/cmake/CMakeLists.txt
@@ -10,7 +10,7 @@ else()
 endif()
 
 set(POLLY_CONFIG_EXPORTED_TARGETS Polly ${ISL_TARGET})
-if (NOT MSVC AND LLVM_ENABLE_PIC)
+if (NOT WIN32 AND LLVM_ENABLE_PIC)
   # LLVMPolly is a dummy target on Win or if PIC code is disabled.
   list(APPEND POLLY_CONFIG_EXPORTED_TARGETS LLVMPolly)
 endif()

diff  --git a/polly/lib/CMakeLists.txt b/polly/lib/CMakeLists.txt
index 113ae5f2eb57..b20358e4b3d6 100644
--- a/polly/lib/CMakeLists.txt
+++ b/polly/lib/CMakeLists.txt
@@ -137,7 +137,7 @@ endif ()
 
 # Create a loadable module Polly.so that can be loaded using
 # LLVM's/clang's "-load" option.
-if (MSVC OR NOT LLVM_ENABLE_PIC)
+if (WIN32 OR NOT LLVM_ENABLE_PIC)
   # Add dummy target, either because loadable modules are not supported
   # as on Windows or because PIC code has been disabled
   add_custom_target(LLVMPolly)


        


More information about the llvm-commits mailing list