[PATCH] D87003: [llvm-cov] Allow commas in filenams passed to `-object` flag

[Andrew Gallagher via Phabricator via llvm-commits]

andrewjcg updated this revision to Diff 291779.
andrewjcg added a comment.

test for something more than exit code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87003/new/

https://reviews.llvm.org/D87003

Files:
  llvm/test/tools/llvm-cov/Inputs/comma,in,path.covmapping
  llvm/test/tools/llvm-cov/comma,in,path.test
  llvm/tools/llvm-cov/CodeCoverage.cpp


Index: llvm/tools/llvm-cov/CodeCoverage.cpp
===================================================================
--- llvm/tools/llvm-cov/CodeCoverage.cpp
+++ llvm/tools/llvm-cov/CodeCoverage.cpp
@@ -544,8 +544,7 @@
       cl::Positional, cl::desc("Covered executable or object file."));
 
   cl::list<std::string> CovFilenames(
-      "object", cl::desc("Coverage executable or object file"), cl::ZeroOrMore,
-      cl::CommaSeparated);
+      "object", cl::desc("Coverage executable or object file"), cl::ZeroOrMore);
 
   cl::list<std::string> InputSourceFiles(
       cl::Positional, cl::desc("<Source files>"), cl::ZeroOrMore);
Index: llvm/test/tools/llvm-cov/comma,in,path.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-cov/comma,in,path.test
@@ -0,0 +1,7 @@
+# Test that llvm-cov's `-object` option handles path with comma.
+
+RUN: llvm-cov show -o %t.dir %S/Inputs/comma,in,path.covmapping -instr-profile=%S/Inputs/report.profdata -path-equivalence=/tmp,%S -name-regex=".*" %s
+RUN: FileCheck -check-prefix=FUNCTIONS -input-file %t.dir/coverage/tmp/report.cpp.txt %s
+FUNCTIONS: _Z3foob
+FUNCTIONS: _Z3barv
+FUNCTIONS: _Z4func


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87003.291779.patch
Type: text/x-patch
Size: 1198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200915/bad84ba9/attachment.bin>