[PATCH] D87631: [AVR] Fix global references to function symbols

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 17:48:52 PDT 2020


aykevl added a comment.

As a quick review (without looking into this carefully): you need to add tests. Without tests this will not be accepted. It also gives a better idea of what it does exactly and thus makes reviewing easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87631/new/

https://reviews.llvm.org/D87631



More information about the llvm-commits mailing list