[PATCH] D80695: [mlir] Added big endian version of "dense-elements-hex.mlir"

Haruki Imai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 17:48:36 PDT 2020


imaihal added a comment.
Herald added a subscriber: tatianashp.

In D80695#2266442 <https://reviews.llvm.org/D80695#2266442>, @mehdi_amini wrote:

> In D80695#2265193 <https://reviews.llvm.org/D80695#2265193>, @imaihal wrote:
>
>> I thought native byte order should be written in `dense.attr`.
>
> Well that's my point all along: let's not do that and make the serialization/deserialization cross-platform.

OK. I will implement the conversion, assuming that HEX in `dens.attr` is always LE. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80695/new/

https://reviews.llvm.org/D80695



More information about the llvm-commits mailing list