[PATCH] D87655: [Bugpoint][NewPM] Pin bugpoint to legacy PM

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 17:19:25 PDT 2020


aeubanks created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
aeubanks requested review of this revision.

Bugpoint has lots of assumptions and hacks around the legacy PM, put off migrating it to NPM until later.
Fixes tests under BugPoint under NPM.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87655

Files:
  llvm/test/BugPoint/unsymbolized.ll
  llvm/tools/bugpoint/OptimizerDriver.cpp


Index: llvm/tools/bugpoint/OptimizerDriver.cpp
===================================================================
--- llvm/tools/bugpoint/OptimizerDriver.cpp
+++ llvm/tools/bugpoint/OptimizerDriver.cpp
@@ -205,6 +205,7 @@
 
   for (unsigned i = 0, e = OptArgs.size(); i != e; ++i)
     Args.push_back(OptArgs[i]);
+  Args.push_back("-enable-new-pm=0");
   Args.push_back("-disable-symbolication");
   Args.push_back("-o");
   Args.push_back(OutputFilename);
Index: llvm/test/BugPoint/unsymbolized.ll
===================================================================
--- llvm/test/BugPoint/unsymbolized.ll
+++ llvm/test/BugPoint/unsymbolized.ll
@@ -3,7 +3,7 @@
 ; RUN: echo "print('args = ' + str(sys.argv))" >> %t.py
 ; RUN: echo "exit(1)" >> %t.py
 ; RUN: not bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crashcalls -opt-command=%python -opt-args %t.py | FileCheck %s
-; RUN: not --crash opt -load %llvmshlibdir/BugpointPasses%shlibext %s -bugpoint-crashcalls -disable-symbolication 2>&1 | FileCheck --check-prefix=CRASH %s
+; RUN: not --crash opt -enable-new-pm=0 -load %llvmshlibdir/BugpointPasses%shlibext %s -bugpoint-crashcalls -disable-symbolication 2>&1 | FileCheck --check-prefix=CRASH %s
 ; RUN: not bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crashcalls -opt-command=%t.non.existent.opt.binary -opt-args %t.py 2>&1 | FileCheck %s --check-prefix=BAD-OPT
 
 ; Test that bugpoint disables symbolication on the opt tool to reduce runtime overhead when opt crashes


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87655.291741.patch
Type: text/x-patch
Size: 1553 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200915/0aabe289/attachment.bin>


More information about the llvm-commits mailing list