[PATCH] D87529: [AArch64][GlobalISel] Refactor + improve CMN, ADDS, and ADD emit functions

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 14:50:35 PDT 2020


aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:181
+  MachineInstr *
+  emitBinOp(const std::array<std::array<unsigned, 2>, 3> &OpcTable,
+            Register Dst, MachineOperand &LHS, MachineOperand &RHS,
----------------
This needs a more descriptive name and doc for the table, e.g. what the rows and columns mean.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87529/new/

https://reviews.llvm.org/D87529



More information about the llvm-commits mailing list