[PATCH] D87401: [ms] [llvm-ml] Add MASM hex float support

[Eric Astor via Phabricator via llvm-commits]

epastor added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3455
+    // MASM hexadecimal floating-point literal; no APFloat conversion needed.
+    // Also, to match ML64.exe, ignore the initial sign.
+    unsigned Size = Value.getSizeInBits(Semantics);
----------------
thakis wrote:
> Should we at least warn about an explicit sign with a hexfloat?
Warning sounds like a good idea. Added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87401/new/

https://reviews.llvm.org/D87401