[PATCH] D87480: [InstCombine] Simplify select operand based on equality condition
    Sanjay Patel via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Sep 14 08:41:36 PDT 2020
    
    
  
spatel added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/select-binop-cmp.ll:567
 
 ; TODO: support for undefs, check for an identity constant does not handle them yet
 define <2 x i8> @select_xor_icmp_vec_bad_2(<2 x i8> %x, <2 x i8> %y, <2 x i8> %z) {
----------------
Remove stale comment and rename test since it's no longer "bad",
================
Comment at: llvm/test/Transforms/InstCombine/select-binop-cmp.ll:606
 
 define i32 @select_and_icmp_bad(i32 %x, i32 %y, i32 %z) {
 ; CHECK-LABEL: @select_and_icmp_bad(
----------------
Rename test - it's not "bad" now.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87480/new/
https://reviews.llvm.org/D87480
    
    
More information about the llvm-commits
mailing list