[PATCH] D87610: [ARM] Fix tail predication predicate tracking

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 07:08:23 PDT 2020


samparker created this revision.
samparker added reviewers: samtebbs, SjoerdMeijer, dmgreen.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls.
Herald added a project: LLVM.
samparker requested review of this revision.

This patch mainly reorganising the logic in ValidateMVEInst because it was a bit difficult to follow... The important change is that we now clear the CurrentPredicate when we find an instruction which would completely overwrite the VPR. This fix essentially means we're back to not really being able to handle VPT instructions when tail predicating.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87610

Files:
  llvm/lib/Target/ARM/ARMInstrVFP.td
  llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/cond-vector-reduce-mve-codegen.ll
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/disjoint-vcmp.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/remat-vctp.ll
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/tp-multiple-vpst.ll
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/vctp-in-vpt-2.mir
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/vpt-blocks.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87610.291566.patch
Type: text/x-patch
Size: 28825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200914/75b7e14f/attachment.bin>


More information about the llvm-commits mailing list