[PATCH] D87270: [Flang] Add GettingInvolved documentation page and sidebar.

Richard Barton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 01:00:59 PDT 2020


richard.barton.arm requested changes to this revision.
richard.barton.arm added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/docs/GettingInvolved.md:56
+-   Join [Flang Community Technical Biweekly Call](https://bluejeans.com/625064848?src=join_info)
+-   Time: Happens every other Monday 8:30 Pacific Time in same week as the Flang Community Biweekly Call.
+-   The agenda is in this [Google Doc](https://docs.google.com/document/d/1Z2U5UAtJ-Dag5wlMaLaW1KRmNgENNAYynJqLW2j2AZQ/).
----------------
I think the original version is correct - this is on the opposite week the the above community biweekly.


================
Comment at: flang/docs/GettingInvolved.md:64
+-   Time: Tuesdays 10:00 AM Pacific Time, every 4 weeks.
+-   The agenda is in this [Google Docs](https://docs.google.com/document/d/1ybwEKDVtIbhIhK50qYtwKsL50K-NvB6LfuBsfepBZ9Y/).
+
----------------
Doc (singular)


================
Comment at: flang/docs/_templates/indexsidebar.html:24
+    <li><a href="https://reviews.llvm.org/">Code Review</a></li>
+<! TODO: Have the bots setup first>
+    <li><a href="#">Doxygen API</a></li>
----------------
sameeranjoshi wrote:
> richard.barton.arm wrote:
> > Does this comment mean buildbots? Could we link to http://lab.llvm.org:8011/console here?
> We need something like http://llvm.org/doxygen/index.html
> From what I understand I think we need one of the buildbots to builds documentation and host them somewhere.
> Not completely sure how this is handled in LLVM.
Understood. Perhaps we could ask the owner of that bot to enable Flang in the build?

No need for that to block progress on this patch though. Happy to go with the TODO for now.


================
Comment at: flang/docs/index.md:25
 
+# Getting Involved
+
----------------
I think this document should be the first document in the "Contributing to Flang" section, rather than as a separate toctree below it. It seems like the perfect intro to folks wanting to work on Flang.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87270/new/

https://reviews.llvm.org/D87270



More information about the llvm-commits mailing list