[PATCH] D86890: [compiler-rt] Remove copy of InstrProfData.inc

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 13 14:13:45 PDT 2020


+1

On Mon, Sep 14, 2020 at 12:00 AM Filipe Cabecinhas via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> I would love to have a single source of truth, but this basically makes it impossible to just build compiler-rt by itself, no?
>
> That path is also “very non portable”, given that our cmake build system can find/be directed to the source for the projects in different places.
>
> Thank you,
>  Filipe
>
> On Sun, 13 Sep 2020 at 20:49, David Li via Phabricator <reviews at reviews.llvm.org> wrote:
>>
>> davidxl added a comment.
>>
>>
>>
>> Change in this direction is welcome. Added vsk and beanz to comment on the implication on runtime builds.
>>
>>
>>
>>
>>
>> Repository:
>>
>>   rG LLVM Github Monorepo
>>
>>
>>
>> CHANGES SINCE LAST ACTION
>>
>>   https://reviews.llvm.org/D86890/new/
>>
>>
>>
>> https://reviews.llvm.org/D86890
>>
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list