[PATCH] D87564: [VPlan] Add vplan native path vectorization test case for inner loop reduction

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 12 11:05:28 PDT 2020


fhahn added a comment.

Thanks for the test! I left a suggestion on how to strengthen the CHECK lines in the test



================
Comment at: llvm/test/Transforms/LoopVectorize/vplan-vectorize-inner-loop-reduction.ll:19
+define void @inner_loop_reduction(double* noalias nocapture readonly %a.in, double* noalias nocapture readonly %b.in, double* noalias nocapture %c.out) {
+; CHECK-LABEL: @inner_loop_reduction(
+; CHECK: fadd <4 x double>
----------------
I think in this case, it would be valuable to add checks for all vectorized blocks and their contents.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87564/new/

https://reviews.llvm.org/D87564



More information about the llvm-commits mailing list