[PATCH] D86928: [SVE][CodeGen] Fix TypeSize/ElementCount related warnings in sve-split-store.ll

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 16:39:41 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:544
+  TypeSize StWidth = StVT.getSizeInBits();
+  TypeSize StSize = StVT.getStoreSizeInBits();
   auto &DL = DAG.getDataLayout();
----------------
I don't think it's possible for StVT to be a vector type here.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2235
+  if (V.getValueType().isScalableVector())
+    return SDValue();
+
----------------
I don't think we should ever get here with a scalable vector?  We should guard the creation of DemandedElts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86928/new/

https://reviews.llvm.org/D86928



More information about the llvm-commits mailing list