[PATCH] D87456: AMDGPU/GlobalISel Check for NoNaNsFPMath in isKnownNeverSNaN

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 14:05:46 PDT 2020


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:471-472
   const MachineInstr *DefMI = MRI.getVRegDef(Val);
   if (!DefMI)
     return false;
 
----------------
Should delete this null check in a separate change


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:474-478
+  if (DefMI->getMF()->getTarget().Options.NoNaNsFPMath)
+    return true;
+
   if (DefMI->getFlag(MachineInstr::FmNoNans))
     return true;
----------------
Could merge these into getFlag() || TM.Options ...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87456/new/

https://reviews.llvm.org/D87456



More information about the llvm-commits mailing list