[PATCH] D83608: [NewPM][CodeGen] Introduce CodeGenPassBuilder to help build codegen pipeline

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:131
+
+    if (!Opt.VerifyMachineCode)
+#ifdef EXPENSIVE_CHECKS
----------------
Add braces


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:827
+    // not-yet-supported input.
+    if (!isGlobalISelAbortEnabled())
+      if (auto Err = derived().addInstSelector(addPass))
----------------
Add braces


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:839
+  // // Print the instruction selected machine code...
+  // printAndVerify("After Instruction Selection");
+
----------------
Commented out code


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:935
+
+  if (TM.Options.EnableIPRA)
+    // Collect register usage information and produce a register mask of
----------------
Add braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83608/new/

https://reviews.llvm.org/D83608