[PATCH] D87477: [ThinLTO] Make -lto-embed-bitcode an enum

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

The change itself looks good to me, but I don't understand this comment from the summary:

> (*) That's the compiler semantics. The driver splits compilation in 2 phases, so if -fembed-bitcode is given to the driver, the .llvmbc is optimized bitcode; if the option is passed to the compiler (after -cc1), the section is pre-optimized.

Are you saying that "clang -fembed-bitcode foo.c -O2 -c" does something different than "clang -cc1 -fembed-bitcode foo.c -O2 -c". That seems strange and broken to me. I thought the intent of the option is to emit pre-optimized code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87477/new/

https://reviews.llvm.org/D87477