[PATCH] D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC

[Andrew Ng via Phabricator via llvm-commits]

andrewng marked 4 inline comments as done.
andrewng added a comment.

In D87469#2267576 <https://reviews.llvm.org/D87469#2267576>, @grimar wrote:

> I think this is fine approach in general. I wonder if it should/could be splitted into 2 patches though:
> one for `InputSectionDescription` and one for `SectionPattern`?

I did consider this, but the changes for both are very similar, somewhat overlap and have the same justification, so that's why I've put them together. However, if the general consensus is that it should be split up, then I'm happy to do this.



================
Comment at: lld/ELF/LinkerScript.cpp:324
+static StringRef getFilename(const InputFile *file) {
+  return file ? file->getNameForScript() : StringRef();
+}
----------------
grimar wrote:
> It feels that `getFilename` can instead be just inlined now, though?
I've inlined the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87469/new/

https://reviews.llvm.org/D87469